consumer(ticdc): do not sort to detect out of order events #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
ti-chi-bot
bot
added
size/M
ti-chi-bot
bot
added
size/L
|
/retest |
1 similar comment
|
/retest |
|
/retest |
3AceShowHand
changed the title
3AceShowHand
changed the title
ti-chi-bot
bot
added
release-note-none
asddongmen
approved these changes
Dec 30, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
wk989898
reviewed
Dec 30, 2024
| @@ -379,31 +386,24 @@ func (w *writer) WriteMessage(ctx context.Context, message *kafka.Message) bool | |||
| w.checkPartition(row, partition, message.TopicPartition.Offset) | |||
|
|
|||
| tableID := row.GetTableID() | |||
| if w.option.protocol != config.ProtocolSimple { | |||
| switch w.option.protocol { | |||
| case config.ProtocolSimple, config.ProtocolCanalJSON: | |||
There was a problem hiding this comment.
Why exclude open protocol?
There was a problem hiding this comment.
Simple and Canal-JSON, the table id is already encoded into the message.
Open-Protocol, table id is only set for the partition table, so we have to generate fake table id for all open protocol encoded messages.
wk989898
approved these changes
Dec 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11947
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note